Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Changes to add KPIs to e2e action #1321

Merged
merged 63 commits into from
Jul 1, 2024
Merged

test: Changes to add KPIs to e2e action #1321

merged 63 commits into from
Jul 1, 2024

Conversation

nathangeology
Copy link
Contributor

Fixes #N/A

Description
Changes the e2e tests to allow for using a python script to extract KPIs from prometheus during the e2e testing.
How was this change tested?
Work in progress. Testing via actions and testing in experimental EKS clusters with Nick Tran.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 14, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 14, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @nathangeology!

It looks like this is your first PR to kubernetes-sigs/karpenter 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/karpenter has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 14, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @nathangeology. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 14, 2024
@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9522661875

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 81.355%
Totals Coverage Status
Change from base Build 9492890501: 0.09%
Covered Lines: 8308
Relevant Lines: 10212
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9522769666

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 81.336%
Files with Coverage Reduction New Missed Lines %
pkg/test/expectations/expectations.go 2 93.69%
Totals Coverage Status
Change from base Build 9492890501: 0.07%
Covered Lines: 8306
Relevant Lines: 10212
💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 18, 2024
njtran
njtran reviewed Jun 20, 2024
View reviewed changes
.github/workflows/kind-e2e.yaml Outdated Show resolved Hide resolved
.github/workflows/kind-e2e.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 25, 2024
@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9667054920

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 103 of 211 (48.82%) changed or added relevant lines in 13 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.8%) to 80.464%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1beta1/nodepool.go 14 15 93.33%
pkg/controllers/disruption/multinodeconsolidation.go 5 6 83.33%
pkg/controllers/disruption/singlenodeconsolidation.go 4 5 80.0%
pkg/controllers/disruption/helpers.go 48 50 96.0%
pkg/apis/v1beta1/zz_generated.deepcopy.go 1 5 20.0%
pkg/test/pods.go 0 99 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/test/expectations/expectations.go 2 93.69%
pkg/apis/v1beta1/nodepool.go 3 95.24%
Totals Coverage Status
Change from base Build 9492890501: -0.8%
Covered Lines: 8320
Relevant Lines: 10340
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9669181172

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 103 of 211 (48.82%) changed or added relevant lines in 13 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.7%) to 80.532%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1beta1/nodepool.go 14 15 93.33%
pkg/controllers/disruption/multinodeconsolidation.go 5 6 83.33%
pkg/controllers/disruption/singlenodeconsolidation.go 4 5 80.0%
pkg/controllers/disruption/helpers.go 48 50 96.0%
pkg/apis/v1beta1/zz_generated.deepcopy.go 1 5 20.0%
pkg/test/pods.go 0 99 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/scheduling/requirements.go 2 98.01%
pkg/apis/v1beta1/nodepool.go 3 95.24%
Totals Coverage Status
Change from base Build 9492890501: -0.7%
Covered Lines: 8327
Relevant Lines: 10340
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9669833534

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 103 of 211 (48.82%) changed or added relevant lines in 13 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.8%) to 80.484%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1beta1/nodepool.go 14 15 93.33%
pkg/controllers/disruption/multinodeconsolidation.go 5 6 83.33%
pkg/controllers/disruption/singlenodeconsolidation.go 4 5 80.0%
pkg/controllers/disruption/helpers.go 48 50 96.0%
pkg/apis/v1beta1/zz_generated.deepcopy.go 1 5 20.0%
pkg/test/pods.go 0 99 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/node/termination/terminator/eviction.go 2 89.09%
pkg/apis/v1beta1/nodepool.go 3 95.24%
Totals Coverage Status
Change from base Build 9492890501: -0.8%
Covered Lines: 8322
Relevant Lines: 10340
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9670176785

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 103 of 211 (48.82%) changed or added relevant lines in 13 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.8%) to 80.513%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1beta1/nodepool.go 14 15 93.33%
pkg/controllers/disruption/multinodeconsolidation.go 5 6 83.33%
pkg/controllers/disruption/singlenodeconsolidation.go 4 5 80.0%
pkg/controllers/disruption/helpers.go 48 50 96.0%
pkg/apis/v1beta1/zz_generated.deepcopy.go 1 5 20.0%
pkg/test/pods.go 0 99 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/test/expectations/expectations.go 2 93.69%
pkg/apis/v1beta1/nodepool.go 3 95.24%
Totals Coverage Status
Change from base Build 9492890501: -0.8%
Covered Lines: 8325
Relevant Lines: 10340
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9670619699

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 103 of 211 (48.82%) changed or added relevant lines in 13 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 80.464%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1beta1/nodepool.go 14 15 93.33%
pkg/controllers/disruption/multinodeconsolidation.go 5 6 83.33%
pkg/controllers/disruption/singlenodeconsolidation.go 4 5 80.0%
pkg/controllers/disruption/helpers.go 48 50 96.0%
pkg/apis/v1beta1/zz_generated.deepcopy.go 1 5 20.0%
pkg/test/pods.go 0 99 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/apis/v1beta1/nodepool.go 3 95.24%
Totals Coverage Status
Change from base Build 9492890501: -0.8%
Covered Lines: 8320
Relevant Lines: 10340
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9683956145

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 103 of 211 (48.82%) changed or added relevant lines in 13 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.7%) to 80.532%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1beta1/nodepool.go 14 15 93.33%
pkg/controllers/disruption/multinodeconsolidation.go 5 6 83.33%
pkg/controllers/disruption/singlenodeconsolidation.go 4 5 80.0%
pkg/controllers/disruption/helpers.go 48 50 96.0%
pkg/apis/v1beta1/zz_generated.deepcopy.go 1 5 20.0%
pkg/test/pods.go 0 99 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/apis/v1beta1/nodepool.go 3 95.24%
Totals Coverage Status
Change from base Build 9492890501: -0.7%
Covered Lines: 8327
Relevant Lines: 10340
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9684146046

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 103 of 211 (48.82%) changed or added relevant lines in 13 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.8%) to 80.513%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1beta1/nodepool.go 14 15 93.33%
pkg/controllers/disruption/multinodeconsolidation.go 5 6 83.33%
pkg/controllers/disruption/singlenodeconsolidation.go 4 5 80.0%
pkg/controllers/disruption/helpers.go 48 50 96.0%
pkg/apis/v1beta1/zz_generated.deepcopy.go 1 5 20.0%
pkg/test/pods.go 0 99 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/expiration.go 2 89.66%
pkg/apis/v1beta1/nodepool.go 3 95.24%
Totals Coverage Status
Change from base Build 9492890501: -0.8%
Covered Lines: 8325
Relevant Lines: 10340
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9684212623

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 103 of 211 (48.82%) changed or added relevant lines in 13 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.7%) to 80.532%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1beta1/nodepool.go 14 15 93.33%
pkg/controllers/disruption/multinodeconsolidation.go 5 6 83.33%
pkg/controllers/disruption/singlenodeconsolidation.go 4 5 80.0%
pkg/controllers/disruption/helpers.go 48 50 96.0%
pkg/apis/v1beta1/zz_generated.deepcopy.go 1 5 20.0%
pkg/test/pods.go 0 99 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/test/expectations/expectations.go 2 93.69%
pkg/apis/v1beta1/nodepool.go 3 95.24%
Totals Coverage Status
Change from base Build 9492890501: -0.7%
Covered Lines: 8327
Relevant Lines: 10340
💛 - Coveralls

@njtran njtran changed the title Changes to add KPIs to e2e action test: Changes to add KPIs to e2e action Jun 26, 2024
@coveralls
Copy link

coveralls commented Jun 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9686832937

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 103 of 211 (48.82%) changed or added relevant lines in 13 files are covered.
  • 19 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.7%) to 80.528%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1beta1/nodepool.go 14 15 93.33%
pkg/controllers/disruption/multinodeconsolidation.go 5 6 83.33%
pkg/controllers/disruption/singlenodeconsolidation.go 4 5 80.0%
pkg/controllers/disruption/helpers.go 48 50 96.0%
pkg/apis/v1beta1/zz_generated.deepcopy.go 1 5 20.0%
pkg/test/pods.go 0 99 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/expiration.go 2 89.66%
pkg/apis/v1beta1/nodepool.go 3 95.24%
pkg/controllers/provisioning/controller.go 14 0.0%
Totals Coverage Status
Change from base Build 9492890501: -0.7%
Covered Lines: 8325
Relevant Lines: 10338
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9686912011

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 103 of 211 (48.82%) changed or added relevant lines in 13 files are covered.
  • 21 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.7%) to 80.528%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/v1beta1/nodepool.go 14 15 93.33%
pkg/controllers/disruption/multinodeconsolidation.go 5 6 83.33%
pkg/controllers/disruption/singlenodeconsolidation.go 4 5 80.0%
pkg/controllers/disruption/helpers.go 48 50 96.0%
pkg/apis/v1beta1/zz_generated.deepcopy.go 1 5 20.0%
pkg/test/pods.go 0 99 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/test/expectations/expectations.go 2 93.69%
pkg/controllers/node/termination/terminator/eviction.go 2 89.09%
pkg/apis/v1beta1/nodepool.go 3 95.24%
pkg/controllers/provisioning/controller.go 14 0.0%
Totals Coverage Status
Change from base Build 9492890501: -0.7%
Covered Lines: 8325
Relevant Lines: 10338
💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 26, 2024
@coveralls
Copy link

coveralls commented Jun 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9687410194

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 78.386%
Totals Coverage Status
Change from base Build 9687383593: 0.08%
Covered Lines: 8722
Relevant Lines: 11127
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9687752044

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 78.368%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/drift.go 2 89.09%
Totals Coverage Status
Change from base Build 9687383593: 0.06%
Covered Lines: 8720
Relevant Lines: 11127
💛 - Coveralls

@nathangeology nathangeology requested a review from njtran June 26, 2024 23:09
@coveralls
Copy link

coveralls commented Jun 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9700182261

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 78.404%
Files with Coverage Reduction New Missed Lines %
pkg/apis/v1/nodepool.go 2 75.95%
pkg/apis/v1beta1/nodepool.go 2 95.24%
Totals Coverage Status
Change from base Build 9687383593: 0.1%
Covered Lines: 8724
Relevant Lines: 11127
💛 - Coveralls

njtran
njtran reviewed Jun 27, 2024
View reviewed changes
.github/workflows/kind-e2e.yaml Outdated Show resolved Hide resolved
.github/workflows/kind-e2e.yaml Outdated Show resolved Hide resolved
.github/workflows/kind-e2e.yaml Show resolved Hide resolved
.github/actions/install-prometheus/values.yaml Outdated Show resolved Hide resolved
.github/workflows/kind-e2e.yaml Outdated Show resolved Hide resolved
.github/workflows/kind-e2e.yaml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
hack/install-kwok.sh Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9706359935

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 66 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.03%) to 78.33%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/controllers.go 1 0.0%
pkg/controllers/nodeclaim/disruption/expiration.go 2 92.31%
pkg/apis/v1/nodepool.go 2 75.95%
pkg/apis/v1/labels.go 2 92.59%
pkg/apis/v1/taints.go 3 0.0%
pkg/operator/operator.go 11 2.99%
pkg/utils/nodeclaim/nodeclaim.go 12 40.52%
pkg/controllers/disruption/controller.go 33 76.09%
Totals Coverage Status
Change from base Build 9687383593: 0.03%
Covered Lines: 8668
Relevant Lines: 11066
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9715594807

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 68 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.007%) to 78.312%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/controllers.go 1 0.0%
pkg/controllers/nodeclaim/disruption/expiration.go 2 92.31%
pkg/apis/v1/nodepool.go 2 75.95%
pkg/apis/v1/labels.go 2 92.59%
pkg/controllers/node/termination/terminator/eviction.go 2 89.09%
pkg/apis/v1/taints.go 3 0.0%
pkg/operator/operator.go 11 2.99%
pkg/utils/nodeclaim/nodeclaim.go 12 40.52%
pkg/controllers/disruption/controller.go 33 76.09%
Totals Coverage Status
Change from base Build 9687383593: 0.007%
Covered Lines: 8666
Relevant Lines: 11066
💛 - Coveralls

njtran
njtran reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nathangeology, njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit b445b7f into kubernetes-sigs:main Jul 1, 2024
13 checks passed
BEvgeniyS pushed a commit to BEvgeniyS/karpenter that referenced this pull request Jul 5, 2024
@nathangeology @njtran @BEvgeniyS
test: Changes to add KPIs to e2e action (kubernetes-sigs#1321)
b6c56c8 
Co-authored-by: Nick Tran <[email protected]>
Co-authored-by: Nick Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njtran njtran njtran left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@tallaxes tallaxes Awaiting requested review from tallaxes

Assignees

@njtran njtran

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nathangeology @k8s-ci-robot @coveralls @njtran